Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test that was not being run #3939

Merged
merged 1 commit into from Oct 10, 2023
Merged

Fix test that was not being run #3939

merged 1 commit into from Oct 10, 2023

Conversation

JelleZijlstra
Copy link
Collaborator

No description provided.

@JelleZijlstra JelleZijlstra added the skip news Pull requests that don't need a changelog entry. label Oct 10, 2023
@JelleZijlstra
Copy link
Collaborator Author

I also looked at the rest of the files in tests/data/ for similar problems. Most files outside cases are in test directories for gitignore/file discovery, so it makes sense to keep those separate. miscellaneous/ has a bunch of other files that probably make sense to keep by themselves for various reasons.

@JelleZijlstra JelleZijlstra merged commit 935f303 into psf:main Oct 10, 2023
39 checks passed
@JelleZijlstra JelleZijlstra deleted the cleantests branch October 10, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JelleZijlstra @hauntsaninja