New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update output display to job summary #3914
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this idea. Makes a lot of sense.
I do wonder tho, can we break people who might be already parsing the output? If so, should we consider making a config parameter (if possible) to disable this code block new default? (I don't know how easy this is to do)
Hi @cooperlees , thanks for the feedback! Regarding your concern, I am not really sure that somebody can/will parse the output? If a user wants to read the output of black, usually he/she will use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I thought this was for human consumption only, was just checking we were not missing anything.
In that case lets add a change log entry so we show somewhere we've decided to make this change and rebase this and I'll merge.
Thankyou for your contribution!
Hey @cooperlees , I noticed that the exit code was not handled correctly, so I updated the PR |
Many thanks again. This will help people see the changes to the code etc. |
I believe this change might have caused the GitHub action to fail without actionable output in some cases, e.g. in a way where the only output is:
|
Description
Black default job summary isn't really readable, since Python code will be converted 1:1 in Markdown, leading to something like this: https://github.com/csalerno-asml/test-black-repo/actions/runs/6380983558#summary-17316480770
With this proposal, the diff will be wrapped in a triple-quoted python box: https://github.com/csalerno-asml/test-black-repo/actions/runs/6380983558#summary-17316481072
Checklist - did you ...
CHANGES.md
if necessary?