Fix removed comments in stub files #3745
Conversation
|
|
||
| def h(): | ||
| ... | ||
| # bye |
There was a problem hiding this comment.
Arguably we could turn this into def h(): ... # bye, but that's more complicated to implement and if the user put it on a separate line, we might as well keep it there.
|
diff-shades reports zero changes comparing this PR (238b176) to main (0b4d7d5).%0A%0A---%0A%0AWhat is this? | Workflow run | diff-shades documentation |
|
I guess it could make more sense for the testing to look at ".pyi" extension instead of "_pyi" stem, but whatever |
|
I think I tried that briefly but there was a fairly deep assumption in the test framework that everything has a |
|
Totally out of the loop, but would you think it would be better in the long run to migrate away from assuming everything is a |
|
Yes, let's do that |
Fixes #1239. Fixes #1020.
I believe we can fix this without going through the preview style as we're only changing code that was not yet formatted with black; https://black.readthedocs.io/en/stable/the_black_code_style/index.html#stability-policy explicitly calls out that we can fix bugs where we remove comments.