Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CITATION.cff file #3723

Merged
merged 7 commits into from Jul 9, 2023
Merged

Add CITATION.cff file #3723

merged 7 commits into from Jul 9, 2023

Conversation

schackartk
Copy link
Contributor

@schackartk schackartk commented Jun 7, 2023

Description

This pull request adds a CITATION.cff file to the root of the repository. This resolves #3722 and follows GitHub's recommendation.

It will achieve several things:

  • Provide explicit information (metadata) on how to cite Black
  • Allow GitHub to automatically generate APA and BibTeX formatted citations
  • Allow reference managers to automatically access the citation metadata

Hopefully, this will make it easier to give due credit to Black!

Further considerations

What metadata to include in this file is subjective, and up to the Black development team. Here are a few considerations. Most are tradeoffs between accuracy and increased maintenance:

  • Should an exhaustive list of authors be added (and maintained), or Łukasz Langa only, or add "the Black development team" as another author, or just have the dev team listed as the author? The latter option seems the most common.
  • Should the version number be added (and maintained)?

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

I don't believe that anything needs to be added to CHANGES.md. Maybe it could be added to the Documentation section?

@ichard26 ichard26 added the skip news Pull requests that don't need a changelog entry. label Jun 7, 2023
@ichard26
Copy link
Collaborator

ichard26 commented Jun 7, 2023

Thanks for the PR!

We can steal what's in the footer of the documentation:

Łukasz Langa and contributors to Black

And I'd discourage maintaining a copy of the version number in the citation file. I recognize it may be helpful for citers, but it would introduce more friction during releases (which I'd like to avoid).

A changelog entry isn't necessary here, but it would be nice either way. Putting it under Documentation would be the way to go.

@JelleZijlstra
Copy link
Collaborator

I think I'd actually prefer a changelog entry, as presumably we want users to know about this. We should omit a changelog entry only if users don't need to know about the change.

@schackartk
Copy link
Contributor Author

I have updated the authorship information and the changelog. Hopefully the authorship information looks okay. If not, I can change it to a single author with the literal string "Łukasz Langa and contributors to Black" instead of divided into 2 author fields.

Regarding version number, I agree, it is much more friction. Also, while version number is important, most citation styles don't include version numbers anyway. So if a user wants to be explicit, they can include that information manually, usually directly in the text.

Copy link
Collaborator

@ichard26 ichard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@schackartk
Copy link
Contributor Author

I see Linting is failing. The message looks like it is making the changes itself, is that correct? Or do I need to make the changes it suggests and commit them?

@JelleZijlstra
Copy link
Collaborator

You need to commit the changes.

@JelleZijlstra JelleZijlstra self-assigned this Jun 23, 2023
@JelleZijlstra JelleZijlstra merged commit f3b50e4 into psf:main Jul 9, 2023
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CITATION.cff file
3 participants