Do not wrap implicitly concatenated strings used as func args in parens. #3640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
diff-shades results comparing this PR (968bb6c) to main (a552f70). The full diff is available in the logs under the "Generate HTML diff report" step. |
|
@JelleZijlstra any opinion on this? I think the preview string processing overall is a very big change, so I think reverting #3307 would be beneficial to get it in the 2024 stable style. |
JelleZijlstra
approved these changes
Apr 28, 2023
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jul 21, 2023
Summary: I thought using the `--preview` flag would make the future transition from black 23.X to 24.X smoother, but unfortunately it is not as stable as I imagined. There is no guarantee that the result of running the linter with this flag will not change on minor upgrade, as we just saw with black 23.7.0 reverting a rule for string formatting (psf/black#3640). The result in this diff was obtained in two steps: - adopt the latest expected future style for multiline concatatenated strings, by first running `arc lint --everything` after upgrading black to 23.7.0 - remove the `--preview` flag from `.arclint`, and rerun `arc lint --everything` The second step does not revert the first one because manually splitting long strings over multiple lines is already compatible with `black` 23.X (it just won't do it automatically for you). Test Plan: check we get the same result for all 23.X versions: ``` pip index versions black for version in 23.1.0 23.3.0 23.7.0 do pip install black==${version} arc lint --everything done ``` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D14294
Fabcien
pushed a commit
to Bitcoin-ABC/ElectrumABC
that referenced
this pull request
Jul 21, 2023
Summary: I thought using the `--preview` flag would make the future transition from black 23.X to 24.X smoother, but unfortunately it is not as stable as I imagined. There is no guarantee that the result of running the linter with this flag will not change on minor upgrade, as we just saw with black 23.7.0 reverting a rule for string formatting (psf/black#3640). The result in this diff was obtained in two steps: - adopt the latest expected future style for multiline concatatenated strings, by first running `arc lint --everything` after upgrading black to 23.7.0 - remove the `--preview` flag from `.arclint`, and rerun `arc lint --everything` The second step does not revert the first one because manually splitting long strings over multiple lines is already compatible with `black` 23.X (it just won't do it automatically for you). Test Plan: check we get the same result for all 23.X versions: ``` pip index versions black for version in 23.1.0 23.3.0 23.7.0 do pip install black==${version} arc lint --everything done ``` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D14294
Fabcien
pushed a commit
to Bitcoin-ABC/ElectrumABC
that referenced
this pull request
Jul 22, 2023
Summary: I thought using the `--preview` flag would make the future transition from black 23.X to 24.X smoother, but unfortunately it is not as stable as I imagined. There is no guarantee that the result of running the linter with this flag will not change on minor upgrade, as we just saw with black 23.7.0 reverting a rule for string formatting (psf/black#3640). The result in this diff was obtained in two steps: - adopt the latest expected future style for multiline concatatenated strings, by first running `arc lint --everything` after upgrading black to 23.7.0 - remove the `--preview` flag from `.arclint`, and rerun `arc lint --everything` The second step does not revert the first one because manually splitting long strings over multiple lines is already compatible with `black` 23.X (it just won't do it automatically for you). Test Plan: check we get the same result for all 23.X versions: ``` pip index versions black for version in 23.1.0 23.3.0 23.7.0 do pip install black==${version} arc lint --everything done ``` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D14294
Fabcien
pushed a commit
to Bitcoin-ABC/ElectrumABC
that referenced
this pull request
Jul 23, 2023
Summary: I thought using the `--preview` flag would make the future transition from black 23.X to 24.X smoother, but unfortunately it is not as stable as I imagined. There is no guarantee that the result of running the linter with this flag will not change on minor upgrade, as we just saw with black 23.7.0 reverting a rule for string formatting (psf/black#3640). The result in this diff was obtained in two steps: - adopt the latest expected future style for multiline concatatenated strings, by first running `arc lint --everything` after upgrading black to 23.7.0 - remove the `--preview` flag from `.arclint`, and rerun `arc lint --everything` The second step does not revert the first one because manually splitting long strings over multiple lines is already compatible with `black` 23.X (it just won't do it automatically for you). Test Plan: check we get the same result for all 23.X versions: ``` pip index versions black for version in 23.1.0 23.3.0 23.7.0 do pip install black==${version} arc lint --everything done ``` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D14294
PiRK
added a commit
to Bitcoin-ABC/ElectrumABC
that referenced
this pull request
Jul 24, 2023
Summary: I thought using the `--preview` flag would make the future transition from black 23.X to 24.X smoother, but unfortunately it is not as stable as I imagined. There is no guarantee that the result of running the linter with this flag will not change on minor upgrade, as we just saw with black 23.7.0 reverting a rule for string formatting (psf/black#3640). The result in this diff was obtained in two steps: - adopt the latest expected future style for multiline concatatenated strings, by first running `arc lint --everything` after upgrading black to 23.7.0 - remove the `--preview` flag from `.arclint`, and rerun `arc lint --everything` The second step does not revert the first one because manually splitting long strings over multiple lines is already compatible with `black` 23.X (it just won't do it automatically for you). Test Plan: check we get the same result for all 23.X versions: ``` pip index versions black for version in 23.1.0 23.3.0 23.7.0 do pip install black==${version} arc lint --everything done ``` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D14294
Fabcien
pushed a commit
to Bitcoin-ABC/ElectrumABC
that referenced
this pull request
Jul 26, 2023
Summary: I thought using the `--preview` flag would make the future transition from black 23.X to 24.X smoother, but unfortunately it is not as stable as I imagined. There is no guarantee that the result of running the linter with this flag will not change on minor upgrade, as we just saw with black 23.7.0 reverting a rule for string formatting (psf/black#3640). The result in this diff was obtained in two steps: - adopt the latest expected future style for multiline concatatenated strings, by first running `arc lint --everything` after upgrading black to 23.7.0 - remove the `--preview` flag from `.arclint`, and rerun `arc lint --everything` The second step does not revert the first one because manually splitting long strings over multiple lines is already compatible with `black` 23.X (it just won't do it automatically for you). Test Plan: check we get the same result for all 23.X versions: ``` pip index versions black for version in 23.1.0 23.3.0 23.7.0 do pip install black==${version} arc lint --everything done ``` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D14294
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts the change in #3307, as the changes that would have been introduced in the 2024 style are too destructive based on feedback. See #2188 (comment).
Checklist - did you ...
CHANGES.mdif necessary?