Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triple quote strings as function args are formatted badly #1333

Open
Mattwmaster58 opened this issue Apr 3, 2020 · 0 comments
Open

Triple quote strings as function args are formatted badly #1333

Mattwmaster58 opened this issue Apr 3, 2020 · 0 comments
Labels
F: strings Related to our handling of strings T: style What do we want Blackened code to look like?

Comments

@Mattwmaster58
Copy link

Mattwmaster58 commented Apr 3, 2020

At the very least, I think black should keep the argument call paren on the same line. Ideally the opening triple quote and opening paren would be on the same line as well.

Examples in the current Black style:

            await isolated_page.evaluate(
                '''() => {
                history.pushState({}, '', '/first.html');
                history.pushState({}, '', '/second.html');
            }'''
            )

Desired style

            await isolated_page.evaluate('''() => {
                history.pushState({}, '', '/first.html');
                history.pushState({}, '', '/second.html');
            }''')

Not sure if this is related to #256

@Mattwmaster58 Mattwmaster58 added the T: style What do we want Blackened code to look like? label Apr 3, 2020
@JelleZijlstra JelleZijlstra added the F: strings Related to our handling of strings label May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: strings Related to our handling of strings T: style What do we want Blackened code to look like?
Projects
None yet
Development

No branches or pull requests

2 participants