-
Notifications
You must be signed in to change notification settings - Fork 15.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip exports if not available by CommonJS #8856
Skip exports if not available by CommonJS #8856
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
c97ce4c
to
8aadc18
Compare
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
@lukesandberg @acozzette Any chance this will get reviewed and integrated in the near future. Otherwise I we will need likely to either patch locally the library or fully replace it with some other lib. 😢 |
@lukesandberg @acozzette |
Ping @lukesandberg @acozzette Is this project still active? |
@Danielku15 Sorry for the delay and thank you for the fix! |
Resolves #8855
This is a minimal fix for the problem reported in the above issue. I added a simplistic check whether the exports variable is an object to be filled. This eliminates the error without making big changes to really extend to an UMD. Proper UMD support (also in the generated code) would likely need a bigger change in code consisting of changes in the file structure, code generator (protoc), tests etc.
My primary goal is to eliminate the browser error.