Add class method Timestamp.from_time to ruby well known types #8562
+11
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was surprised to find out that
from_time
was not a class method, but an instance method.This limits its usefulness, as to create a new Timestamp you have to first instantiate the object, then call the from_time method, and then you need to return/use the saved instance, because the from_time method returns the self.nanos value, rather than the timestamp itself.
Code example
Before
After