Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only substitute prefixes during installation setup. #14907

Merged
merged 1 commit into from Nov 30, 2023

Conversation

mkruskal-google
Copy link
Member

This caused an issue on some platforms where protobuf/java/core/src/main/java/com/google/protobuf/java_features.proto was getting turned into the invalid path java/core/src/main/java/com/google/java_features.proto.

Fixes #14862

PiperOrigin-RevId: 586478133

This caused an issue on some platforms where `protobuf/java/core/src/main/java/com/google/protobuf/java_features.proto` was getting turned into the invalid path `java/core/src/main/java/com/google/java_features.proto`.

Fixes protocolbuffers#14862

PiperOrigin-RevId: 586478133
@mkruskal-google mkruskal-google added the back-port Cherrypick PRs to release branches label Nov 30, 2023
@mkruskal-google mkruskal-google requested a review from a team as a code owner November 30, 2023 04:26
@mkruskal-google mkruskal-google added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Nov 30, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Nov 30, 2023
@zhangskz zhangskz merged commit 59eebe3 into protocolbuffers:25.x Nov 30, 2023
159 of 161 checks passed
@mkruskal-google mkruskal-google deleted the cmake-install-fix branch November 30, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-port Cherrypick PRs to release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants