Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.x] Backport deps: Update Guava 32.0.1 #13106

Merged
merged 1 commit into from Jun 20, 2023
Merged

[23.x] Backport deps: Update Guava 32.0.1 #13106

merged 1 commit into from Jun 20, 2023

Conversation

chadlwilson
Copy link
Contributor

Backport of #13099


Follow-up from #13002 to update to 32.0.1 to fix an issue on windows:

https://github.com/google/guava/releases/tag/v32.0.1

The underlying issue likely does not affect protobuf as it does not appear to (directly) use the affected Files.createTempDir or FileBackedOutputStream code which was apparently broken on Windows in 32.0.0.

Seems best to update anyway.

Follow-up from #12953 to update to `32.0.1` to fix an issue on windows:

https://github.com/google/guava/releases/tag/v32.0.1

The underlying issue likely does not affect protobuf as it does not appear to (directly) use the affected `Files.createTempDir` or `FileBackedOutputStream` code which was apparently broken on Windows in `32.0.0`.

Seems best to update anyway.

(cherry picked from commit c95ebb7)
@chadlwilson chadlwilson requested a review from a team as a code owner June 20, 2023 17:18
@chadlwilson chadlwilson requested review from shaod2 and removed request for a team June 20, 2023 17:18
@perezd perezd requested review from mkruskal-google and removed request for shaod2 June 20, 2023 17:19
@mkruskal-google mkruskal-google added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jun 20, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jun 20, 2023
@zhangskz zhangskz merged commit 571fae4 into protocolbuffers:23.x Jun 20, 2023
140 of 141 checks passed
@chadlwilson chadlwilson deleted the backport-bump-guava-3201 branch June 21, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants