Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dllexport_decl for generated default instance. (#13085) #13090

Merged
merged 2 commits into from Jun 16, 2023

Conversation

fowles
Copy link
Member

@fowles fowles commented Jun 16, 2023

Fixes #13084

Closes #13085

COPYBARA_INTEGRATE_REVIEW=#13085 from owent:add_dllexport_decl_for_generated_default_instance a46d4e8 PiperOrigin-RevId: 540938351

…3085)

Fixes protocolbuffers#13084

Closes protocolbuffers#13085

COPYBARA_INTEGRATE_REVIEW=protocolbuffers#13085 from owent:add_dllexport_decl_for_generated_default_instance a46d4e8
PiperOrigin-RevId: 540938351
@fowles fowles marked this pull request as ready for review June 16, 2023 18:22
@fowles fowles requested review from a team as code owners June 16, 2023 18:22
@fowles fowles added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jun 16, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jun 16, 2023
@mkruskal-google mkruskal-google added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jun 16, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jun 16, 2023
@fowles fowles merged commit 62d7b37 into protocolbuffers:23.x Jun 16, 2023
140 of 141 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants