Add dllexport_decl for generated default instance. #13085
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fowles
approved these changes
Jun 16, 2023
fowles
added
c++
🅰️ safe for tests
fowles
pushed a commit
to fowles/protobuf
that referenced
this pull request
Jun 16, 2023
…3085) Fixes protocolbuffers#13084 Closes protocolbuffers#13085 COPYBARA_INTEGRATE_REVIEW=protocolbuffers#13085 from owent:add_dllexport_decl_for_generated_default_instance a46d4e8 PiperOrigin-RevId: 540938351
fowles
added a commit
that referenced
this pull request
Jun 16, 2023
Add dllexport_decl for generated default instance. (#13085)
|
Cheery picked back to 23.x so this will be in the next point release which is pending on #13075 |
phuchau1989
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13084