Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify port_def.inc to ignore -Wshadow warning #13059

Closed
wants to merge 1 commit into from
Closed

Modify port_def.inc to ignore -Wshadow warning #13059

wants to merge 1 commit into from

Conversation

4kangjc
Copy link
Contributor

@4kangjc 4kangjc commented Jun 14, 2023

Closes #13037

@4kangjc 4kangjc requested a review from a team as a code owner June 14, 2023 17:41
@4kangjc 4kangjc requested review from sbenzaquen and removed request for a team June 14, 2023 17:41
@fowles fowles added c++ 🅰️ safe for tests Mark a commit as safe to run presubmits over labels Jun 14, 2023
@fowles
Copy link
Member

fowles commented Jun 14, 2023

there was a thing in our tree that held up our automation. Do you mind rebasing to latest?

@fowles fowles added cleanup and removed 🅰️ safe for tests Mark a commit as safe to run presubmits over labels Jun 14, 2023
@fowles fowles added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jun 14, 2023
@4kangjc
Copy link
Contributor Author

4kangjc commented Jun 15, 2023

there was a thing in our tree that held up our automation. Do you mind rebasing to latest?

OK.

@fowles fowles added 🅰️ safe for tests Mark a commit as safe to run presubmits over and removed 🅰️ safe for tests Mark a commit as safe to run presubmits over labels Jun 15, 2023
@4kangjc
Copy link
Contributor Author

4kangjc commented Jun 16, 2023

@fowles Is there anything else that needs to be changed?

@fowles
Copy link
Member

fowles commented Jun 16, 2023

no, we need to kick a few things on our side

fowles pushed a commit to fowles/protobuf that referenced this pull request Jun 16, 2023
@4kangjc @fowles
Modify port_def.inc to ignore -Wshadow warning (protocolbuffers#13059)
6241d42 
Closes protocolbuffers#13037

Closes protocolbuffers#13059

COPYBARA_INTEGRATE_REVIEW=protocolbuffers#13059 from 4kangjc:main 71b2fc5
PiperOrigin-RevId: 540886449
@fowles fowles mentioned this pull request Jun 16, 2023
Merged
fowles added a commit that referenced this pull request Jun 16, 2023
@fowles
Merge pull request #13088 from fowles/23.x
528e673 
Modify port_def.inc to ignore -Wshadow warning (#13059)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fowles fowles fowles approved these changes

@sbenzaquen sbenzaquen Awaiting requested review from sbenzaquen sbenzaquen is a code owner automatically assigned from protocolbuffers/protobuf-compiler

Assignees
No one assigned
Labels
🅰️ safe for tests Mark a commit as safe to run presubmits over c++ cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename shadowed variables
2 participants
@4kangjc @fowles