Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ODR violation from WKT codegen #12406

Closed
wants to merge 5 commits into from
Closed

Remove ODR violation from WKT codegen #12406

wants to merge 5 commits into from

Conversation

mkruskal-google
Copy link
Member

No description provided.

@mkruskal-google mkruskal-google requested review from a team as code owners April 5, 2023 00:37
@mkruskal-google mkruskal-google added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Apr 5, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Apr 5, 2023
@mkruskal-google mkruskal-google added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Apr 5, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Apr 5, 2023
@mkruskal-google mkruskal-google added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Apr 5, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Apr 5, 2023
haberman
haberman approved these changes Apr 5, 2023
View reviewed changes
src/google/protobuf/BUILD.bazel Show resolved Hide resolved
src/google/protobuf/BUILD.bazel Outdated Show resolved Hide resolved
@mkruskal-google mkruskal-google added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Apr 5, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Apr 5, 2023
@mkruskal-google mkruskal-google added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Apr 5, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Apr 5, 2023
@mkruskal-google mkruskal-google added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Apr 5, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Apr 5, 2023
@mkruskal-google mkruskal-google added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Apr 5, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Apr 5, 2023
@jtattermusch
Copy link
Contributor

CC @jtattermusch

@copybara-service copybara-service bot mentioned this pull request Apr 6, 2023
Closed
copybara-service bot pushed a commit that referenced this pull request Apr 6, 2023
@haberman
Remove ODR violation from WKT codegen (#12406)
437e7fb 
Closes #12406

COPYBARA_INTEGRATE_REVIEW=#12406 from mkruskal-google:wkt 1c6748e
FUTURE_COPYBARA_INTEGRATE_REVIEW=#12406 from mkruskal-google:wkt 1c6748e
PiperOrigin-RevId: 522407931
copybara-service bot pushed a commit that referenced this pull request Apr 6, 2023
@haberman
Remove ODR violation from WKT codegen (#12406)
43e1aff 
Closes #12406

COPYBARA_INTEGRATE_REVIEW=#12406 from mkruskal-google:wkt 1c6748e
FUTURE_COPYBARA_INTEGRATE_REVIEW=#12406 from mkruskal-google:wkt 1c6748e
PiperOrigin-RevId: 522407931
copybara-service bot pushed a commit that referenced this pull request Apr 6, 2023
@haberman
Remove ODR violation from WKT codegen (#12406)
3875f03 
Closes #12406

COPYBARA_INTEGRATE_REVIEW=#12406 from mkruskal-google:wkt 1c6748e
FUTURE_COPYBARA_INTEGRATE_REVIEW=#12406 from mkruskal-google:wkt 1c6748e
PiperOrigin-RevId: 522407931
@copybara-service copybara-service bot closed this in f519230 Apr 6, 2023
haberman pushed a commit to haberman/protobuf that referenced this pull request Apr 6, 2023
@mkruskal-google @haberman
Remove ODR violation from WKT codegen (protocolbuffers#12406)
8b34c16 
Closes protocolbuffers#12406

COPYBARA_INTEGRATE_REVIEW=protocolbuffers#12406 from mkruskal-google:wkt 1c6748e
PiperOrigin-RevId: 522418175
@haberman haberman mentioned this pull request Apr 6, 2023
Merged
haberman added a commit that referenced this pull request Apr 6, 2023
@haberman @mkruskal-google
Remove ODR violation from WKT codegen (#12406) (#12419)
5ddb1fc 
* Remove ODR violation from WKT codegen (#12406)

Closes #12406

COPYBARA_INTEGRATE_REVIEW=#12406 from mkruskal-google:wkt 1c6748e
PiperOrigin-RevId: 522418175

* Removed legacy target.

---------

Co-authored-by: Mike Kruskal <mkruskal@google.com>
bithium pushed a commit to bithium/protobuf that referenced this pull request Sep 4, 2023
@mkruskal-google
Remove ODR violation from WKT codegen (protocolbuffers#12406)
c294b14 
Closes protocolbuffers#12406

COPYBARA_INTEGRATE_REVIEW=protocolbuffers#12406 from mkruskal-google:wkt 1c6748e
PiperOrigin-RevId: 522418175
bithium pushed a commit to bithium/protobuf that referenced this pull request Sep 4, 2023
@haberman @mkruskal-google
Remove ODR violation from WKT codegen (protocolbuffers#12406) (protoc…
1b359f3 
…olbuffers#12419)

* Remove ODR violation from WKT codegen (protocolbuffers#12406)

Closes protocolbuffers#12406

COPYBARA_INTEGRATE_REVIEW=protocolbuffers#12406 from mkruskal-google:wkt 1c6748e
PiperOrigin-RevId: 522418175

* Removed legacy target.

---------

Co-authored-by: Mike Kruskal <mkruskal@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haberman haberman haberman approved these changes

Assignees
No one assigned
Labels
bazel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mkruskal-google @jtattermusch @haberman