Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed deprecation warning for new Buffer #1905

Merged

Conversation

panther7
Copy link
Contributor

Used Buffer.alloc if it's available.

#1411

@panther7
Copy link
Contributor Author

^ @alexander-fenster Please, can you check it? Thanks

src/reader.js Outdated Show resolved Hide resolved
@panther7 panther7 force-pushed the fixed-deprecation-warning-buffer branch 2 times, most recently from a1bd21f to 93894d5 Compare August 21, 2023 18:20
@panther7 panther7 force-pushed the fixed-deprecation-warning-buffer branch from 93894d5 to 33d852f Compare August 21, 2023 18:41
@panther7
Copy link
Contributor Author

Fixed eslint

@panther7 panther7 force-pushed the fixed-deprecation-warning-buffer branch from 33d852f to a3c8463 Compare August 21, 2023 19:02
@alexander-fenster alexander-fenster merged commit e93286e into protobufjs:master Aug 21, 2023
6 checks passed
@alexander-fenster
Copy link
Contributor

Thank you!

@github-actions github-actions bot mentioned this pull request Aug 21, 2023
@panther7 panther7 deleted the fixed-deprecation-warning-buffer branch August 22, 2023 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants