Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More blending correspondances #724

Merged
merged 6 commits into from
Feb 6, 2025
Merged

More blending correspondances #724

merged 6 commits into from
Feb 6, 2025

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Feb 5, 2025

Description

Add more blending correspondences

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Sorry, something went wrong.


- # Wildcard import
- pylint: wildcard-import
- pyflakes: F403
- frosted: E103
- ruff: F403
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be multiple Ruff codes as Ruff also reimplement pylint for exemple.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see that Ruff also reimplemented PyLint, I see "only" Flake8, isort, and Black! Did I miss something?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not everything is reimplemented, all the multi-file analysis aren't

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :-)

@sbrunner sbrunner marked this pull request as ready for review February 5, 2025 14:16
Copy link
Collaborator

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I didn't check all the correspondances :)

@sbrunner sbrunner merged commit 63d4e11 into master Feb 6, 2025
5 checks passed
@sbrunner sbrunner deleted the more-blending branch February 6, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants