[proptest] silence clippy::arc_with_non_send_sync warning with prop_oneof #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
…neof Often, the strategies passed into `prop_oneof!` are `BoxedStrategy` instances, which are not Send or Sync. Rust 1.72 has a new `arc_with_non_send_sync` clippy lint that fires in these cases. The double-curly-braces are not strictly required, but allow the expression to be annotated with an attribute.
sunshowers
force-pushed
the
prop-oneof-non-send
branch
from
82b5e06
to
93c67a0
Compare
matthew-russo
approved these changes
Aug 25, 2023
cameron1024
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often, the strategies passed into
prop_oneof!areBoxedStrategyinstances, which are not Send or Sync. Rust 1.72 has a newarc_with_non_send_syncclippy lint that fires in these cases.The double-curly-braces are not strictly required, but allow the expression to be annotated with an attribute.