docs: additional formatting fixes to 3.0 migration guide #15379
Merged
+27
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fiona Liao <fiona.liao@grafana.com>
Signed-off-by: Fiona Liao <fiona.liao@grafana.com>
Signed-off-by: Fiona Liao <fiona.liao@grafana.com>
Signed-off-by: Fiona Liao <fiona.liao@grafana.com>
bwplotka
reviewed
Nov 11, 2024
| following regular expressions now match the accompanying strings, whereas in | ||
| Prometheus v2 these combinations didn't match. | ||
|
|
||
| | Regex | Additional matches | |
There was a problem hiding this comment.
Is it really more readable without table? The text feels quite dense now:
There was a problem hiding this comment.
I think the table would be better, but I didn't figure out a way to get it to display properly on the website. I think tables don't work well with nanoc/kramdown when they're indented within bulleted lists.
Currently the PromQL section looks like:
With the table section messed up
bwplotka
approved these changes
Nov 11, 2024
Signed-off-by: Fiona Liao <fiona.liao@grafana.com>
jan--f
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly more newlines/spaces/bullet points being added
Changed the table used to explain the
.regex change to bullet points as I couldn't figure out a way to get an indented table to display properly on the website 😅.Preview: https://deploy-preview-2540--prometheus-docs.netlify.app/docs/prometheus/latest/migration/ (made some hacky changes to prometheus/docs to do this preview: prometheus/docs#2540)