Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Scraping: Tolerance should be max 1% of interval #13737

Merged
merged 1 commit into from Mar 8, 2024

Conversation

bboreham
Copy link
Member

@bboreham bboreham commented Mar 8, 2024

Previous code set it at minimum 1%, which was not intended.

Fixes #13730

Previous code set it at minimum 1%, which was not intended.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
@machine424
Copy link
Collaborator

Thanks,
I think we should update

a.Flag("scrape.timestamp-tolerance", "Timestamp tolerance. See https://github.com/prometheus/prometheus/issues/7846 for more context. Experimental. This flag will be removed in a future release.").
to mention that we go with 1% of the interval now (and we no longer skip as before.)

@machine424
Copy link
Collaborator

But we didn't mention that alignments were skipped if the tolerance is greater than 1% of the scrape interval, so we can keep it like that. Your call.

@bboreham
Copy link
Member Author

bboreham commented Mar 8, 2024

The docstring didn't explain much before, so I don't feel it's essential to improve it in this PR.
Maybe we could do a subsequent PR that takes the feature out of experimental status, and documents it clearly.

@bboreham bboreham merged commit 54f50e1 into prometheus:main Mar 8, 2024
24 checks passed
@bboreham bboreham deleted the fix-scrape-tolerance branch March 8, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--scrape.timestamp-tolerance is no longer respected
3 participants