Add native histograms to latency/duration metrics #13681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krajorama
requested review from
jesusvazquez,
cstyan,
bwplotka and
tomwilkie
as code owners
krajorama
force-pushed
the
native-latency-histograms
branch
from
6c53414
to
5d7479a
Compare
Dogfood native histograms. Allow dependent projects to migrate to native histograms. I took the defaults from client_golang. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
krajorama
force-pushed
the
native-latency-histograms
branch
from
5d7479a
to
4d4d822
Compare
beorn7
approved these changes
Mar 7, 2024
Merged
krajorama
added a commit
to grafana/mimir
that referenced
this pull request
Mar 12, 2024
Includes fix to rate calculation prometheus/prometheus#13725 And some native histograms prometheus/prometheus#13681 Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2 tasks
krajorama
added a commit
to grafana/mimir
that referenced
this pull request
Mar 12, 2024
* Vendor update mimir-prometheus at 2b3d9c010123 Includes fix to rate calculation prometheus/prometheus#13725 And some native histograms prometheus/prometheus#13681 * Copy private const strings from Alertmanager. Note: these are again public on main in alertmanager. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Itaykal
pushed a commit
to Itaykal/mimir
that referenced
this pull request
Mar 13, 2024
* Vendor update mimir-prometheus at 2b3d9c010123 Includes fix to rate calculation prometheus/prometheus#13725 And some native histograms prometheus/prometheus#13681 * Copy private const strings from Alertmanager. Note: these are again public on main in alertmanager. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dogfood native histograms.
Allow dependent projects to migrate to native histograms.
I've excluded non time related metrics to limit the scope and also they usually have their own idea of buckets.
I took the defaults from client_golang.