Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync golangcli-lint workflow with https://github.com/prometheus/node_exporter/blob/master/.github/workflows/golangci-lint.yml #520

Merged
merged 2 commits into from May 16, 2023

Conversation

conallob
Copy link
Contributor

@conallob conallob commented May 16, 2023

Highlights include bumping golangci-lint-action to v3.4.0, Release Notes: https://github.com/golangci/golangci-lint-action/releases/tag/v3.4.0

@SuperQ
Copy link
Member

SuperQ commented May 16, 2023

I would recommend copying the current node_exporter config wholesale.

@conallob conallob changed the title Update golangci/golangci-lint-action to v3.4.0 Sync golangcli-lint workflow with https://github.com/prometheus/node_exporter/blob/master/.github/workflows/golangci-lint.yml May 16, 2023
@conallob
Copy link
Contributor Author

I would recommend copying the current node_exporter config wholesale.

Done. Perhaps it should be in it's own repository some day.

@SuperQ
Copy link
Member

SuperQ commented May 16, 2023

We used to have this script automatically synced from prometheus/prometheus, but the CI there was reworked and we stopped updating it. :(

@conallob
Copy link
Contributor Author

We used to have this script automatically synced from prometheus/prometheus, but the CI there was reworked and we stopped updating it. :(

Have you considered a mono repo? :P

@SuperQ SuperQ merged commit 24c2637 into prometheus:master May 16, 2023
8 checks passed
@discordianfish
Copy link
Member

Yeah we should have a dedicated repo for gh actions and use them in all other repos with uses.

@conallob
Copy link
Contributor Author

If somebody in @prometheus can create the new repository for GitHub actions, I'm happy to make PRs to move things around

@SuperQ
Copy link
Member

SuperQ commented May 20, 2023

@roidelapluie Was planning to move more of the CircleCI flows to actions. Not sure where that project ended up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants