From cfc11d81f7ed62cfc8d98ea4f60bd2486636e2e1 Mon Sep 17 00:00:00 2001 From: Alberto Donato Date: Sun, 22 Oct 2023 10:11:03 +0200 Subject: [PATCH 1/2] Mark collector parameter as optional in ProcessCollector Signed-off-by: Alberto Donato --- prometheus_client/process_collector.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/prometheus_client/process_collector.py b/prometheus_client/process_collector.py index 8a38d056..2894e874 100644 --- a/prometheus_client/process_collector.py +++ b/prometheus_client/process_collector.py @@ -1,5 +1,5 @@ import os -from typing import Callable, Iterable, Union +from typing import Callable, Iterable, Optional, Union from .metrics_core import CounterMetricFamily, GaugeMetricFamily, Metric from .registry import Collector, CollectorRegistry, REGISTRY @@ -20,7 +20,7 @@ def __init__(self, namespace: str = '', pid: Callable[[], Union[int, str]] = lambda: 'self', proc: str = '/proc', - registry: CollectorRegistry = REGISTRY): + registry: Optional[CollectorRegistry] = REGISTRY): self._namespace = namespace self._pid = pid self._proc = proc From 0600a3d69d84bee1f38365ffa71dd26ccd0b85b5 Mon Sep 17 00:00:00 2001 From: Alberto Donato Date: Tue, 24 Oct 2023 08:50:36 +0200 Subject: [PATCH 2/2] Mark collector parameter as optional in PlatformCollector Signed-off-by: Alberto Donato --- prometheus_client/platform_collector.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/prometheus_client/platform_collector.py b/prometheus_client/platform_collector.py index f99caa68..6040fcce 100644 --- a/prometheus_client/platform_collector.py +++ b/prometheus_client/platform_collector.py @@ -9,7 +9,7 @@ class PlatformCollector(Collector): """Collector for python platform information""" def __init__(self, - registry: CollectorRegistry = REGISTRY, + registry: Optional[CollectorRegistry] = REGISTRY, platform: Optional[Any] = None, ): self._platform = pf if platform is None else platform