Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add restricted registry documentation #968

Merged
merged 6 commits into from Oct 24, 2023

Conversation

remijouannet
Copy link
Contributor

@remijouannet remijouannet commented Oct 19, 2023

i found this undocumented feature in the code, it's pretty useful to debug an exporter that return thousand of metrics.
i don't know if having this feature undocumented was intentional or not
(@csmarchbanks)

Signed-off-by: remi <remijouannet@gmail.com>
Copy link
Member

@csmarchbanks csmarchbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

One note, you can also define a restricted registry from code, perhaps document how to do that as well as the name[] behavior?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Signed-off-by: remi <remijouannet@gmail.com>
Signed-off-by: remi <remijouannet@gmail.com>
Copy link
Member

@csmarchbanks csmarchbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small suggestions, but generally 👍!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
remijouannet and others added 3 commits October 24, 2023 17:35
Co-authored-by: Chris Marchbanks <csmarchbanks@gmail.com>
Signed-off-by: Remi Jouannet <remijouannet@gmail.com>
Co-authored-by: Chris Marchbanks <csmarchbanks@gmail.com>
Signed-off-by: Remi Jouannet <remijouannet@gmail.com>
Co-authored-by: Chris Marchbanks <csmarchbanks@gmail.com>
Signed-off-by: Remi Jouannet <remijouannet@gmail.com>
@csmarchbanks
Copy link
Member

Thanks!

@csmarchbanks csmarchbanks merged commit e56cfda into prometheus:master Oct 24, 2023
10 checks passed
@remijouannet remijouannet deleted the doc_restricted branch October 24, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants