New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.12 #956
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Similar to what you did for python 3.10, would you be willing to update setup.py and .circleci/config.yml as well? If not I can do that in a separate PR.
Signed-off-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Signed-off-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Signed-off-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Done, but it looks like CircleCI doesn't support Python 3.12 yet?
|
Ah bummer, it does look that way. If it is ok I will leave this for a couple weeks until there is a 3.12 image and I can re-run the test then? Since the tests all pass for you locally we shouldn't need to update anything at least! |
Fine by me to wait for the image :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reran the 3.12 test now that there is an image. Thanks!
The second Python 3.12 release candidate is out! π
Python 3.12.0 final is due out in two weeks: 2023-10-02.
Tested locally via tox: