Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change #!/usr/bin/python to #!/usr/bin/env python #945

Merged
merged 3 commits into from Sep 11, 2023

Conversation

kishan-23
Copy link
Contributor

This was creating python version issues during installation. usr/bin/python points to a different version of python, than used in virtual env. Somehow, due to restrictions, can't change usr/bin/python. So changed to #!/usr/bin/env python. Already have a PR merged for this issue.

Kishan Verma added 3 commits June 25, 2023 21:26
Signed-off-by: Kishan Verma <kishanverma2312@gmail.com>
Signed-off-by: Kishan Verma <kishanverma2312@gmail.com>
Signed-off-by: Kishan Verma <kishanverma2312@gmail.com>
@roidelapluie
Copy link
Member

Is this up to date and has actual test failure or does it need a rebase for tests to pass?

Copy link
Member

@csmarchbanks csmarchbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failure is due to not being up to date with a fix to the tests. Merging anyway.

@csmarchbanks csmarchbanks merged commit 34553ad into prometheus:master Sep 11, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants