Gauge typing improvement #935
Conversation
rafsaf
force-pushed
the
gauge_typing_improve
branch
from
bb99445
to
af20d77
Compare
prometheus_client/metrics.py
Outdated
| @@ -17,6 +18,9 @@ | |||
| from .samples import Exemplar, Sample | |||
| from .utils import floatToGoString, INF | |||
|
|
|||
| if sys.version_info >= (3, 8, 0): | |||
There was a problem hiding this comment.
Python 3.7 was just marked EOL a couple weeks ago, which reminded me to open #936. What would you think of merging that first so we do not need this check?
I do want to have that PR available for a couple of days for any comments/objections.
There was a problem hiding this comment.
Sure! I noticed python 3.6 and 3.7 around the repository and decided not to break it.
Let's then wait for the other PR and I will happily rebase
There was a problem hiding this comment.
Support for 3.7 has been removed, so feel free to rebase this PR. Thank you!
rafsaf
force-pushed
the
gauge_typing_improve
branch
from
af20d77
to
e136d82
Compare
Signed-off-by: rafsaf <rafal.safin12@gmail.com>
…codebase Signed-off-by: rafsaf <rafal.safin12@gmail.com>
rafsaf
force-pushed
the
gauge_typing_improve
branch
from
e136d82
to
acad5e2
Compare
|
Rebased after #936 Included removal of old sys.version_info code around project as a bit of refactoring |
prometheus_client/decorator.py
Outdated
There was a problem hiding this comment.
This file is actually copied from https://github.com/micheles/decorator to avoid any dependencies and we do not want to modify it locally. At some point i need to update the version, but for now can we just keep it the same?
Signed-off-by: rafsaf <rafal.safin12@gmail.com>
|
@csmarchbanks thanks, done: decorator.py left untouched |
For python +3.8, use Literal for multiprocess_mode param in Gauge