Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for exporters with direct HTTPS/TLS support #930

Closed
andy-maier opened this issue Jul 3, 2023 · 3 comments
Closed

Add support for exporters with direct HTTPS/TLS support #930

andy-maier opened this issue Jul 3, 2023 · 3 comments
Labels

Comments

@andy-maier
Copy link
Contributor

The node exporter supports HTTPS between the exporter and Prometheus directly since 2020 (https://o11y.eu/blog/prometheus-tls/).

I did not find anything in this package related to the support of HTTPS/TLS between the exporter and Prometheus.

Is it supported? If so, please point me to the documentation or an example.
If not, please consider this a feature request.

@andy-maier andy-maier changed the title Add support for exporters with direct HTTPS support Add support for exporters with direct HTTPS/TLS support Jul 3, 2023
@csmarchbanks
Copy link
Member

We do not have a built in way to create an HTTPS server directly. In the Go libraries the client library also does not have a way to stand up an HTTPS server, but there is https://github.com/prometheus/exporter-toolkit/ which provides some helpers for things like TLS. I am not sure if we would want to add TLS directly to this client or create a similar helper package for users creating exporters.

@karezachen
Copy link
Contributor

karezachen commented Jul 23, 2023

I'm not sure if I can directly modify def start_wsgi_server() .
This is what I did in my own program.

@andy-maier
Copy link
Contributor Author

This was addressed by PR #946, which meanwhile got merged. I am closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants