feat: Add new CollectorFunc utility #1724
Merged
+161
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saumyacodes-40 <saumyabshah90@gmail.com>
Saumya40-codes
requested review from
ArthurSens,
bwplotka,
kakkoyun and
vesari
as code owners
Signed-off-by: Saumyacodes-40 <saumyabshah90@gmail.com>
…/Saumya40-codes/client_golang into implement-new-collectorfunc-util
bwplotka
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Thanks! Amazing 💪🏽
Can we also add one example to https://github.com/prometheus/client_golang/blob/main/prometheus/examples_test.go ?
Signed-off-by: Saumyacodes-40 <saumyabshah90@gmail.com>
Signed-off-by: Saumyacodes-40 <saumyabshah90@gmail.com>
Signed-off-by: Saumyacodes-40 <saumyabshah90@gmail.com>
I've added an example related to CollectorFunc there, can you PTAL? |
ying-jeanne
pushed a commit
to ying-jeanne/client_golang
that referenced
this pull request
Mar 28, 2025
* feat: add CollectorFunc utility Signed-off-by: Saumyacodes-40 <saumyabshah90@gmail.com> * update Signed-off-by: Saumyacodes-40 <saumyabshah90@gmail.com> * added license to the test Signed-off-by: Saumyacodes-40 <saumyabshah90@gmail.com> * address req changes Signed-off-by: Saumyacodes-40 <saumyabshah90@gmail.com> * update license part in test file Signed-off-by: Saumyacodes-40 <saumyabshah90@gmail.com> * add collectorFunc example to prometheus/examples_test.go Signed-off-by: Saumyacodes-40 <saumyabshah90@gmail.com> --------- Signed-off-by: Saumyacodes-40 <saumyabshah90@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue it is resolving
Resolves #1701
Description of changes
CollectorFuncutility inpromethuespackage.CollectandDescribefunctions,CollectorFuncjust requires to haveCollectlogic in it. Thus reducing extraboilerplatecode (under certain scenerios)CollectorFuncfunction that it leverages theDescribeByCollectorfunctionTesting
collectorfunc_test.go(more test might be needed)cc: @bwplotka