Add support for reading PagerDuty secrets from files #3107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 13, 2022 18:03
Signed-off-by: Oktarian Tilney-Bassett <oktariantilneybassett@improbable.io>
Signed-off-by: Oktarian Tilney-Bassett <oktariantilneybassett@improbable.io>
Signed-off-by: Oktarian Tilney-Bassett <oktariantilneybassett@improbable.io>
Signed-off-by: Oktarian Tilney-Bassett <oktariantilneybassett@improbable.io>
qinxx108
pushed a commit
to qinxx108/alertmanager
that referenced
this pull request
Nov 16, 2022
* Add support for reading PagerDuty secrets from files * Update documentation Signed-off-by: Oktarian Tilney-Bassett <oktariantilneybassett@improbable.io> Signed-off-by: Yijie Qin <qinyijie@amazon.com>
qinxx108
pushed a commit
to qinxx108/alertmanager
that referenced
this pull request
Dec 13, 2022
* Add support for reading PagerDuty secrets from files * Update documentation Signed-off-by: Oktarian Tilney-Bassett <oktariantilneybassett@improbable.io> Signed-off-by: Yijie Qin <qinyijie@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow PagerDuty
service_keyandrouting_keyto be read from files. Inspired by #2623 by @sinkingpoint but updated, resolved conflicts and added documentation.Related to issue #2498
Signed-off-by: Oktarian Tilney-Bassett oktariantilneybassett@improbable.io