Log Response Details for Notifier errors for Webhooks, Pushover and VictorOps #3103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oktarian Tilney-Bassett <oktariantilneybassett@improbable.io>
OktarianTB
changed the title
Signed-off-by: Oktarian Tilney-Bassett <oktariantilneybassett@improbable.io>
OktarianTB
force-pushed
the
log-response-details
branch
from
3d683e9
to
e7da911
Compare
Signed-off-by: Oktarian Tilney-Bassett <oktariantilneybassett@improbable.io>
Co-authored-by: Simon Pasquier <spasquie@redhat.com> Signed-off-by: Oktarian T-B <oktariantilneybassett@improbable.io>
|
thanks! |
qinxx108
pushed a commit
to qinxx108/alertmanager
that referenced
this pull request
Nov 16, 2022
…ictorOps (prometheus#3103) * Pass in response body to Retrier Check * Custom error details for webhook notifier Signed-off-by: Oktarian Tilney-Bassett <oktariantilneybassett@improbable.io> Signed-off-by: Yijie Qin <qinyijie@amazon.com>
qinxx108
pushed a commit
to qinxx108/alertmanager
that referenced
this pull request
Dec 13, 2022
…ictorOps (prometheus#3103) * Pass in response body to Retrier Check * Custom error details for webhook notifier Signed-off-by: Oktarian Tilney-Bassett <oktariantilneybassett@improbable.io> Signed-off-by: Yijie Qin <qinyijie@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor improvement to fix #3057 for Webhook, Pushover and VictorOps notifiers to make it easier to debug errors. Lmk if there is a reason not to do this.
Signed-off-by: Oktarian Tilney-Bassett oktariantilneybassett@improbable.io