Truncate messages with fewer characters #3072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: charlie4284 <charlie4284@gmail.com>
qinxx108
pushed a commit
to qinxx108/alertmanager
that referenced
this pull request
Dec 13, 2022
Signed-off-by: charlie4284 <charlie4284@gmail.com> Signed-off-by: charlie4284 <charlie4284@gmail.com> Signed-off-by: Yijie Qin <qinyijie@amazon.com>
pstibrany
reviewed
Sep 4, 2023
| @@ -90,7 +90,7 @@ func Truncate(s string, n int) (string, bool) { | |||
| if n <= 3 { | |||
| return string(r[:n]), true | |||
| } | |||
| return string(r[:n-3]) + "...", true | |||
| return string(r[:n-1]) + "…", true | |||
There was a problem hiding this comment.
"…" is encoded as 3 bytes in utf-8, so this makes string longer by 2 bytes compared to previous version.
Furthermore blindly cutting last 3 or 1 byte can actually break the utf-8 sequence of bytes. Ideally string would be truncated at rune boundary.
There was a problem hiding this comment.
I fixed this eventually: https://github.com/prometheus/alertmanager/blob/main/notify/util.go#L88-L130
There was a problem hiding this comment.
Oh nice, I missed that when checking changelog of alertmanager 0.26.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace three dots characters
...with ellipsis (U+2026)…characters to save 2 extra chars space.Related issue: #3050