Add check for templated Opsgenie receiver config #3060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves prometheus#2887, where Opsgenie responder type can be templated according to docs, but configuration logic checked for specific list of values only. Signed-off-by: Erki Esken <erki@esken.net>
erkiesken
force-pushed
the
fix-opsgenie-responder-type-config
branch
from
0925fea
to
f58aee3
Compare
Co-authored-by: Simon Pasquier <spasquie@redhat.com> Signed-off-by: Erki Esken <erki@esken.net>
|
Hey @simonpasquier. Any blockers to merge this? And any information about when is the next release? |
simonpasquier
approved these changes
Dec 7, 2022
qinxx108
pushed a commit
to qinxx108/alertmanager
that referenced
this pull request
Dec 13, 2022
* Add check for templated Opsgenie receiver config Solves prometheus#2887, where Opsgenie responder type can be templated according to docs, but configuration logic checked for specific list of values only. Signed-off-by: Erki Esken <erki@esken.net> Co-authored-by: Simon Pasquier <spasquie@redhat.com> Signed-off-by: Yijie Qin <qinyijie@amazon.com>
hoperays
pushed a commit
to hoperays/alertmanager
that referenced
this pull request
Apr 23, 2023
* Add check for templated Opsgenie receiver config Solves prometheus#2887, where Opsgenie responder type can be templated according to docs, but configuration logic checked for specific list of values only. Signed-off-by: Erki Esken <erki@esken.net> Co-authored-by: Simon Pasquier <spasquie@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #2887, where Opsgenie responder type can be templated according to docs, but configuration logic checked for specific list of values only.