Trim contents of slack api urls from files #2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please fix the DCO and create a test case for this? Thanks! |
|
Sure, here you go 😸 |
Signed-off-by: Sarah Brofeldt <sarah@qtr.dk>
simonpasquier
approved these changes
Aug 5, 2022
|
you'd need to fix the test |
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
|
thanks! |
qinxx108
pushed a commit
to qinxx108/alertmanager
that referenced
this pull request
Dec 13, 2022
* Trim contents of slack api urls from files Signed-off-by: Sarah Brofeldt <sarah@qtr.dk> * notify/slack: fix test imports Signed-off-by: Simon Pasquier <spasquie@redhat.com> Signed-off-by: Sarah Brofeldt <sarah@qtr.dk> Signed-off-by: Simon Pasquier <spasquie@redhat.com> Co-authored-by: Simon Pasquier <spasquie@redhat.com> Signed-off-by: Yijie Qin <qinyijie@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trailing newlines will almost always be present in a posixish file, so trim it away at first opportunity to prevent having invalid URLs we won't discover until a notification is sent.