UI: add 'Link' button to alerts in list #2880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds a button to each alert that allows linking to a single alert. This works by generating a link that filters on _all_ of the alert's label values, similar to the button to create a new silence from an alert. Signed-off-by: Christopher Taylor <chris.taylor@soundcloud.com>
Signed-off-by: Christopher Taylor <chris.taylor@soundcloud.com>
|
Visually, the changes look good and seem like a decent improvement to link individual alerts. However, I'm in no capacity to review the FE changes - perhaps @w0rm you can please take a look? Here are a couple of screenshots to confirm what it looks like: Before clicking on "Link"
After clicking on "Link"
|
|
thanks for taking a look @gotjosh! Originally, I wanted this to copy the resulting URL to the clipboard, but I wasn't able to figure out how to access the clipboard (I'm not experienced with Elm). This change at least makes it easy to copy the link from the browser's address bar. |
|
is there any interest in this? If not, I'd close the PR in a week or so |
|
@ccmtaylor apologies! LGTM |
qinxx108
pushed a commit
to qinxx108/alertmanager
that referenced
this pull request
Dec 13, 2022
* add 'Link' button adds a button to each alert that allows linking to a single alert. This works by generating a link that filters on _all_ of the alert's label values, similar to the button to create a new silence from an alert. Signed-off-by: Christopher Taylor <chris.taylor@soundcloud.com> * update asset/assets_vfsdata.go Signed-off-by: Christopher Taylor <chris.taylor@soundcloud.com> Signed-off-by: Christopher Taylor <chris.taylor@soundcloud.com> Signed-off-by: Yijie Qin <qinyijie@amazon.com>
qinxx108
pushed a commit
to qinxx108/alertmanager
that referenced
this pull request
Jan 10, 2023
* add 'Link' button adds a button to each alert that allows linking to a single alert. This works by generating a link that filters on _all_ of the alert's label values, similar to the button to create a new silence from an alert. Signed-off-by: Christopher Taylor <chris.taylor@soundcloud.com> * update asset/assets_vfsdata.go Signed-off-by: Christopher Taylor <chris.taylor@soundcloud.com> Signed-off-by: Christopher Taylor <chris.taylor@soundcloud.com> Signed-off-by: Yijie Qin <qinyijie@amazon.com>
qinxx108
pushed a commit
to qinxx108/alertmanager
that referenced
this pull request
Jan 12, 2023
* add 'Link' button adds a button to each alert that allows linking to a single alert. This works by generating a link that filters on _all_ of the alert's label values, similar to the button to create a new silence from an alert. Signed-off-by: Christopher Taylor <chris.taylor@soundcloud.com> * update asset/assets_vfsdata.go Signed-off-by: Christopher Taylor <chris.taylor@soundcloud.com> Signed-off-by: Christopher Taylor <chris.taylor@soundcloud.com> Signed-off-by: Yijie Qin <qinyijie@amazon.com>
qinxx108
pushed a commit
to qinxx108/alertmanager
that referenced
this pull request
Jan 12, 2023
* add 'Link' button adds a button to each alert that allows linking to a single alert. This works by generating a link that filters on _all_ of the alert's label values, similar to the button to create a new silence from an alert. Signed-off-by: Christopher Taylor <chris.taylor@soundcloud.com> * update asset/assets_vfsdata.go Signed-off-by: Christopher Taylor <chris.taylor@soundcloud.com> Signed-off-by: Christopher Taylor <chris.taylor@soundcloud.com> Signed-off-by: Yijie Qin <qinyijie@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a button to each alert that allows linking to a single alert.
This works by generating a link that filters on all of the alert's
label values, similar to the button to create a new silence from an
alert.