Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log deprecated bearer token fields at debug level #6495

Merged
merged 1 commit into from Apr 10, 2024

Conversation

simonpasquier
Copy link
Contributor

Description

Closes #6493

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Verification

Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.

Changelog entry

Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.


@simonpasquier simonpasquier requested a review from a team as a code owner April 10, 2024 07:42
@juzhao
Copy link

juzhao commented Apr 10, 2024

@simonpasquier do we need to change for
level.Warn(cg.logger).Log("msg", "'bearerToken' is deprecated, use 'authorization' instead.")
there are 3 such warnings in 0.73.0, example:
https://github.com/prometheus-operator/prometheus-operator/blob/release-0.73/pkg/prometheus/promcfg.go#L1740

@slashpai slashpai disabled auto-merge April 10, 2024 09:20
@slashpai
Copy link
Contributor

we missed here as Junqi said

level.Warn(cg.logger).Log("msg", "'bearerToken' is deprecated, use 'authorization' instead.")

@simonpasquier
Copy link
Contributor Author

I left them because these fields are both deprecated and not recommended for use because they expose the tokens directly in the Prometheus object.

@slashpai
Copy link
Contributor

Should we add more details why it was deprecated or may be in docs?

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@slashpai slashpai merged commit c383b81 into prometheus-operator:release-0.73 Apr 10, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants