feat: add support for Hetzner SD in ScrapeConfig CRD #6436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slashpai
reviewed
Mar 26, 2024
|
The CI was failing because some linting checks failed. The logs didn't specify on which line of code the linter was failing, I had to run the linting process locally to know that. Don't you think we should improve that ? maybe linting should be part of "make all" ? |
|
You are likely getting errors due to merge conflicts |
|
@mouad-eh Can you rebase your branch? There were multiple PRs for SDs so thats why you have got merge conflicts |
…er ScrapeConfig spec
mouad-eh
force-pushed
the
support_hetzner_sd_config
branch
from
21d3935
to
98dd6ea
Compare
|
@slashpai Done. |
slashpai
reviewed
Apr 3, 2024
|
If changes looks good from your side move to ready for review from draft |
slashpai
approved these changes
Apr 3, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I am using this Draft PR as example to illustrate some implementation details in my GSOC proposal. Feel free to ignore it if you are not reviewing my GSOC proposal.
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.