Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: enqueue in updating secret #6412

Merged

Conversation

jamshidi799
Copy link
Contributor

Add enqueueForPrometheusNamespace to secret update handler
It will fix #6309

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Verification

Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.

Changelog entry

Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.

Add enqueueForPrometheusNamespace in secret update handler

@jamshidi799 jamshidi799 requested a review from a team as a code owner March 20, 2024 08:33
@haanhvu
Copy link
Contributor

haanhvu commented Mar 20, 2024

Thanks for the PR! Do you think we need an e2e test case to replicate the issue? 🤔

Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we'd need an e2e test to verify this but it's a bit more involved. I also think that we should reduce code duplication since all controllers have similar patterns for configmap/secret handlers but again it doesn't need to be in this be in this PR.
TL;DR: I'm fine merging as-is but I'll create more issues to follow-up.

@jamshidi799
Copy link
Contributor Author

I'm interested in working on these code duplication as well

@simonpasquier simonpasquier reopened this Mar 20, 2024
@simonpasquier simonpasquier merged commit f574775 into prometheus-operator:main Mar 20, 2024
30 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PrometheusAgent not reconciled when Secret/Configmap
3 participants