Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bodySizeLimit to service and pod monitors #6349

Merged

Conversation

jamshidi799
Copy link
Contributor

Support EnforcedBodySizeLimit configuration field at the ServiceMonitor and PodMonitor CRD level

Fixes #6244
sorry, I messed up with the branch of this pull request so I created a new pull request

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Changelog entry

Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.

Support EnforcedBodySizeLimit configuration field at the ServiceMonitor and PodMonitor CRD level

@jamshidi799 jamshidi799 requested a review from a team as a code owner February 29, 2024 10:46
pkg/apis/monitoring/v1/podmonitor_types.go Outdated Show resolved Hide resolved
pkg/apis/monitoring/v1/servicemonitor_types.go Outdated Show resolved Hide resolved
pkg/prometheus/promcfg.go Outdated Show resolved Hide resolved
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you run make --always-make format generate and commit the changes?

Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some really small comments, almost there!

go.mod Show resolved Hide resolved
pkg/prometheus/promcfg.go Show resolved Hide resolved
pkg/prometheus/promcfg_test.go Show resolved Hide resolved
@simonpasquier simonpasquier changed the title feat: add EnforcedBodySizeLimit to service and monitor feat: add bodySizeLimit to service and pod monitors Mar 11, 2024
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@simonpasquier simonpasquier merged commit bc0b842 into prometheus-operator:main Mar 12, 2024
17 checks passed
@jamshidi799
Copy link
Contributor Author

Thank you @simonpasquier for reviews and comments

mviswanathsai pushed a commit to mviswanathsai/prometheus-operator that referenced this pull request Mar 13, 2024
…tor#6349)

* feat: add EnforcedBodySizeLimit to service and monitor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prometheus scrape body_size_limit in ServiceMonitor.
3 participants