feat: add keep_dropped_targets limit to CRDs #5897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slashpai
force-pushed
the
KeepDroppedTargets
branch
from
21c3fea
to
cf90df4
Compare
Merged
slashpai
force-pushed
the
KeepDroppedTargets
branch
from
cf90df4
to
4dcfa34
Compare
ArthurSens
approved these changes
Sep 7, 2023
slashpai
force-pushed
the
KeepDroppedTargets
branch
from
4dcfa34
to
0665ea5
Compare
|
@simonpasquier updated with changes |
slashpai
force-pushed
the
KeepDroppedTargets
branch
from
0665ea5
to
4633080
Compare
Fixes prometheus-operator#5875 Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
slashpai
force-pushed
the
KeepDroppedTargets
branch
from
4633080
to
d7622cd
Compare
|
Fixed the test, I dont remember why int was used for limits in tests in past. I updated to use uint64 since thats the type anyways. Also removed redundant tests. I will create separate PR for other limit tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5875
Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Adds keep_dropped_targets limit to CRDs at global as well as scrape level. Also added enforced fields
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.