fix: apply externalLabels after reserved labels in prometheus #5888
Conversation
API document says following about externalLabels field: // The labels to add to any time series or alerts when communicating with // external systems (federation, remote storage, Alertmanager). // Labels defined by `spec.replicaExternalLabelName` and // `spec.prometheusExternalLabelName` take precedence over this list. But in code externalLabels were applied after reserved labels. This commit is to fix that. Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
slashpai
force-pushed
the
externalLabelfix
branch
from
77f33de
to
33fb0bb
Compare
|
@simonpasquier updated with changes and unit test |
|
@simonpasquier @slashpai I have currently the following error in the latest version of the Operator and I believe it's related to this MR: I created the issue #5908 |
commented on issue |
Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
API document says following about externalLabels field:
But in code externalLabels were applied after reserved labels.
This commit is to fix that.
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.