fix: Fix KuberenetesSDConfigs in ScrapeConfig #5871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
verified e2etest was failing without fix https://github.com/prometheus-operator/prometheus-operator/actions/runs/6033952217/job/16371448708?pr=5871#step:9:373 |
Fixes prometheus-operator#5870 Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
slashpai
changed the title
slashpai
commented
Aug 31, 2023
| @@ -241,8 +241,6 @@ func testPromOperatorStartsWithoutScrapeConfigCRD(t *testing.T) { | |||
|
|
|||
| // testScrapeConfigKubernetesNodeRole tests whether Kubernetes node monitoring works as expected | |||
| func testScrapeConfigKubernetesNodeRole(t *testing.T) { | |||
| skipPrometheusTests(t) | |||
There was a problem hiding this comment.
This was culprit for skipping e2e test which didn't catch regression due to https://github.com/prometheus-operator/prometheus-operator/pull/5709/files#diff-453ce9c721c51bf9591c2b212e9ce50157b9c40d1b211177bf502be268099656L2298
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
I am first testing if e2e test fails for current code and then I will uncomment the fix. Also added unit test missed in feature PR
Fixes #5870
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.