fix: support text-only email configs #5804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
|
I've tested locally: when setting |
| @@ -699,10 +699,10 @@ type EmailConfig struct { | |||
| Headers []KeyValue `json:"headers,omitempty"` | |||
| // The HTML body of the email notification. | |||
| // +optional | |||
| HTML string `json:"html,omitempty"` | |||
| HTML *string `json:"html,omitempty"` | |||
There was a problem hiding this comment.
Do still wanna make improvements and bug fixed on alpha apis?
There was a problem hiding this comment.
for now, v1alpha1 is still the default version being installed. I started #5398 a while ago to move forward with v1beta1 but no time to complete it for now...
ArthurSens
approved these changes
Aug 20, 2023
philipgough
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #5421
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.