Fix panic when collecting metrics from Prometheus Agent controller

[ArthurSens]

Description

Fixes #5508

Just waiting for confirmation in case the mentioned new label is really needed 🤔

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

• CHANGE (fix or feature that would cause existing functionality to not work as expected)
• FEATURE (non-breaking change which adds functionality)
• BUGFIX (non-breaking change which fixes an issue)
• ENHANCEMENT (non-breaking change which improves existing functionality)
• NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Changelog entry

Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.

Fix panic when collecting metrics from agent controller

[simonpasquier]

lgtm. Have you checked that it fixes the issue? I guess we also need an e2e test that scrapes metrics from the operator :)
Can you submit the PR against the release-0.64 branch? I'll cut a 0.64.1 release.

[philipgough]

Looks good but would also like to see an e2e test

[slashpai]

Can we add #5476 also in 0.64.1 to avoid alerting when crd not installed? I am working on changes

[ArthurSens]

Agreed that an e2e would be great here, but I'm struggling to do so to be honest 😓 #5471

[ArthurSens]

Manual tests worked tho

[simonpasquier]

@slashpai I'm afraid that the change won't apply cleanly on the release-0.64 branch because of #5472

[simonpasquier]

I'm fine with the e2e test in a follow-up PR.

[simonpasquier]

Manual tests worked tho

I assume that you've checked prometheus_operator_spec_replicas too?

[ArthurSens]

Manual tests worked tho

I assume that you've checked prometheus_operator_spec_replicas too?

I did not, just one sec 😛

[ArthurSens]

Yeah, all good!

Tested with prometheus and prometheus agent running at the same time

[JoaoBraveCoding]

lgtm

[simonpasquier]

@ArthurSens any chance you can rebase your change on top of the release-0.64 branch?

[ArthurSens]

Rebased on top of release-0.64, I'm not sure I have the permissions to change the PR target branch though

[simonpasquier]

I'm not sure I have the permissions to change the PR target branch though

As the author, you should see the Edit button at the top of the page.

[ArthurSens]

I'm not sure I have the permissions to change the PR target branch though

As the author, you should see the Edit button at the top of the page.

TIL!