Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix possible nil reassign #393

Merged
merged 2 commits into from
Apr 24, 2024
Merged

fix possible nil reassign #393

merged 2 commits into from
Apr 24, 2024

Conversation

dogancanbakir
Copy link
Member

Closes #392

@dogancanbakir dogancanbakir self-assigned this Apr 22, 2024
@ehsandeep ehsandeep requested review from tarunKoyalwar and removed request for Mzack9999 April 24, 2024 07:28
tarunKoyalwar

This comment was marked as outdated.

@tarunKoyalwar tarunKoyalwar self-requested a review April 24, 2024 08:55
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

minor update to avoid potential confusion or future issue

@ehsandeep ehsandeep merged commit 363d31d into main Apr 24, 2024
7 checks passed
@ehsandeep ehsandeep deleted the fix_possible_nil_reassign branch April 24, 2024 09:02
@ehsandeep ehsandeep linked an issue Apr 24, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix possible nil reassign in http:readNNormalizeRespBody panic in readNNormalizeRespBody
3 participants