Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix auth err when username is empty #338

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Fix auth err when username is empty #338

merged 3 commits into from
Feb 20, 2024

Conversation

RamanaReddy0M
Copy link
Contributor

@RamanaReddy0M RamanaReddy0M commented Feb 19, 2024 •
edited

tarunKoyalwar
tarunKoyalwar approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

Minor change , moved anonymous function to global scope to make it. more readable

@tarunKoyalwar tarunKoyalwar merged commit f803b96 into main Feb 20, 2024
7 checks passed
@tarunKoyalwar tarunKoyalwar deleted the fix-invalid-resp-err-auth branch February 20, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarunKoyalwar tarunKoyalwar tarunKoyalwar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RamanaReddy0M @tarunKoyalwar