Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Template Locations (#3705) #3926

Merged

Conversation

kchason
Copy link
Contributor

@kchason kchason commented Jul 13, 2023

Proposed changes

Addresses #3705 by allowing environment variables to disable each of the default and custom template locations. This behavior was discussed in #3706.

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update env variable in format of DISABLE_NUCLEI_TEMPLATES_$TYPE_DOWNLOAD?

@kchason
Copy link
Contributor Author

kchason commented Jul 14, 2023

@ehsandeep done in this PR and the documentation PR

Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !!

thanks @kchason for PR .
do you perhaps use any vscode extension / tool for spell check 😄 ??

@kchason
Copy link
Contributor Author

kchason commented Jul 17, 2023

Yep! I use JetBrains' GoLand, it's really nifty so I try to clean up things as I see them

@ehsandeep ehsandeep merged commit 08e1ab9 into projectdiscovery:dev Jul 17, 2023
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Update of Only Custom Templates
3 participants