Webhook payload decoding broken in latest release (v13.0.1)

[vedantmgoyal9]

Webhook deliveries started failing as soon as I upgraded to Probot v13.0.1.

[wolfy1339]

can you share more details on your environment?

What is the HTTP response returned from Probot?

[wolfy1339]

Unfortunately I cannot reproduce this issue.
How are you passing through your webhook secret?

[wolfy1339]

Are you able to attach a debugger to the process and trace down the issue?

[Uzlopak]

What version of probot did you use before?

Not that this is due to octokit/webhooks.js#917 octokit/webhooks.js#916 octokit/webhooks.js#915

[Uzlopak]

Did you ensure that your webhook secret is correctly set?

It can be that your bot was before using a broken @octokit/webhooks package and it did not throw despite having an invalid secret configured.

So please ensure this.
Other than that, we can not reproduce it, solely based on the code you provided as it is actually a configuration issue.

[Uzlopak]

Please provide a minimal viable code example.

[Uzlopak]

Did you upgrade the example repo and deploy on vercel and could you reproduce the issue?

[Uzlopak]

I will put this repo on our todo list for upgrading to probot 13.
Do you deploy on vercel?

[Uzlopak]

Do you deploy your project on vercel?

[Uzlopak]

OK, investigated the issue.

The issue arises from the fact, that vercel preparses the body. So verify can not verify the body, as it is not a string.

You can get it to work for now, by setting NODEJS_HELPERS as Environment variable in vercel and as value you set it to 0.

See https://vercel.com/docs/functions/serverless-functions/runtimes/node-js#disabling-helpers-for-node.js

Then probot would work with vercel.

Using the Node.js Runtime with Serverless Functions

Learn how to use the Node.js runtime to compile Node.js Serverless Functions on Vercel.

[Uzlopak]

Proposed a PR to fix this issue octokit/webhooks.js#962 (comment)

[AaronDewes]

#1964 may provide a better way of supporting Vercel & other platforms going forward.