Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix previous/next button #1898

Merged
merged 2 commits into from
Nov 14, 2023
Merged

docs: Fix previous/next button #1898

merged 2 commits into from
Nov 14, 2023

Conversation

AaronDewes
Copy link
Member

Related to probot/probot.github.io#525, fixes the previous and next buttons on the docs which were not working properly anymore.

@AaronDewes AaronDewes requested a review from a team as a code owner November 13, 2023 19:21
@AaronDewes AaronDewes requested a review from gr2m November 13, 2023 19:36
@Uzlopak
Copy link
Collaborator

Uzlopak commented Nov 13, 2023

@AaronDewes

Why not target beta branch?

@AaronDewes
Copy link
Member Author

Because this change affects our current website, which uses the master branch.

@gr2m
Copy link
Contributor

gr2m commented Nov 14, 2023

I assume the failing tests are unrelated? Node 10, my goodness it's time to upgrade.

@AaronDewes
Copy link
Member Author

I assume the failing tests are unrelated? Node 10, my goodness it's time to upgrade.

Yes, that was because of typescript updates. v13 will hopefully fix it.

@AaronDewes AaronDewes merged commit c1f0767 into master Nov 14, 2023
2 of 11 checks passed
@AaronDewes AaronDewes deleted the fix-docs branch November 14, 2023 06:41
Copy link

🎉 This PR is included in version 12.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 13.0.0-beta.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants