Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax nits to make IntelliJ happy #417

Merged
merged 2 commits into from
Mar 17, 2023
Merged

Syntax nits to make IntelliJ happy #417

merged 2 commits into from
Mar 17, 2023

Conversation

ikonst
Copy link
Contributor

@ikonst ikonst commented Jan 16, 2022 •
edited

  • React.Props type is deprecated
  • Rewrite comma expression

ikonst
ikonst commented Jan 16, 2022
View reviewed changes
index.tsx Outdated Show resolved Hide resolved
ikonst
ikonst commented Jan 16, 2022
View reviewed changes
index.tsx
@@ -206,7 +202,10 @@ const ATTRIBUTE_TO_JSX_PROP_MAP = [
'srcSet',
'tabIndex',
'useMap',
].reduce((obj, x) => ((obj[x.toLowerCase()] = x), obj), { for: 'htmlFor' })
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IntelliJ was complaining about comma expressions

ikonst
ikonst commented Jan 16, 2022
View reviewed changes
index.tsx
@@ -975,6 +974,7 @@ export function compiler(

const createElementFn = options.createElement || React.createElement

// JSX custom pragma
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not adding // noinspection JSUnusedLocalSymbols since it'd probably break the eslint override, but at least explaining what's going on

ikonst
ikonst commented Jan 16, 2022
View reviewed changes
index.tsx Outdated Show resolved Hide resolved
@ikonst ikonst marked this pull request as draft January 16, 2022 21:06
@ikonst
Copy link
Contributor Author

ikonst commented Jan 18, 2022

@probablyup wdyt?

quantizor
quantizor approved these changes Aug 9, 2022
View reviewed changes
Copy link
Owner

@quantizor quantizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quantizor
Copy link
Owner

@ikonst looks like this PR is marked as a draft, anything else you were planning on doing to it?

@ikonst ikonst marked this pull request as ready for review August 9, 2022 14:50
@ikonst
Copy link
Contributor Author

ikonst commented Aug 9, 2022

Nope, I think it's good to merge.

@quantizor quantizor merged commit a05effa into quantizor:main Mar 17, 2023
@ikonst ikonst deleted the nits branch March 17, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quantizor quantizor quantizor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ikonst @quantizor