fix(cjs): implicit resolution to correctly try extensions

Author: privatenumber

src/cjs/api/resolve-implicit-extensions.ts

@@ -13,9 +13,11 @@ const tryExtensions = (
 	...args: Parameters<ResolveFilename>
 ) => {
 	for (const extension of implicitlyResolvableExtensions) {
+		const newArgs = args.slice() as Parameters<ResolveFilename>;
+		newArgs[0] += extension;
+
 		try {
-			args[0] += extension;
-			return resolve(...args);
+			return resolve(...newArgs);
 		} catch {}
 	}
 };

tests/specs/api.ts

@@ -286,16 +286,24 @@ export default testSuite(({ describe }, node: NodeApis) => {
 						const { message, async } = api.require('./file', __filename);
 						console.log(message);
 						async.then(m => console.log(m.default));
+
+						api.require('./tsx?query=1', __filename);
+						api.require('./jsx', __filename);
+						api.require('./dir?query=3', __filename);
 						`,
 						...tsFiles,
+
+						'tsx.tsx': 'console.log(\'tsx\');',
+						'jsx.jsx': 'console.log(\'jsx\');',
+						'dir/index.jsx': 'console.log(\'dir\');',
 					});
 
 					const { stdout } = await execaNode(fixture.getPath('require.cjs'), [], {
 						nodePath: node.path,
 						nodeOptions: [],
 					});
 
-					expect(stdout).toBe('foo bar json file.ts\nasync');
+					expect(stdout).toBe('foo bar json file.ts\ntsx\njsx\ndir\nasync');
 				});
 			});
 		});